-
-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes (missing alt-text, uninformative link text, missing anchor) #876
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-876 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-11-20 13:06:37 +0000 |
Looks good to me! Thanks for these fixes. |
Auto-generated via {sandpaper} Source : 9dd055c Branch : main Author : Naupaka Zimmerman <[email protected]> Time : 2023-11-21 00:06:03 +0000 Message : Merge pull request #876 from matthieu-bruneaux/main Minor fixes (missing alt-text, uninformative link text, missing anchor)
Auto-generated via {sandpaper} Source : 346ac49 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-11-21 00:12:12 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9dd055c Branch : main Author : Naupaka Zimmerman <[email protected]> Time : 2023-11-21 00:06:03 +0000 Message : Merge pull request #876 from matthieu-bruneaux/main Minor fixes (missing alt-text, uninformative link text, missing anchor)
Auto-generated via {sandpaper} Source : 9dd055c Branch : main Author : Naupaka Zimmerman <[email protected]> Time : 2023-11-21 00:06:03 +0000 Message : Merge pull request #876 from matthieu-bruneaux/main Minor fixes (missing alt-text, uninformative link text, missing anchor)
Auto-generated via {sandpaper} Source : f8142e4 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-11-21 00:14:20 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9dd055c Branch : main Author : Naupaka Zimmerman <[email protected]> Time : 2023-11-21 00:06:03 +0000 Message : Merge pull request #876 from matthieu-bruneaux/main Minor fixes (missing alt-text, uninformative link text, missing anchor)
Closes #875.
Minor fixes to avoid the "Unchanged files with check annotations" notification when reviewing PRs:
I am pretty confident the changes are ok, but maybe @skanwal or @naupaka could confirm it is fine before merging? Thanks!