Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes (missing alt-text, uninformative link text, missing anchor) #876

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

matthieu-bruneaux
Copy link
Contributor

Closes #875.

Minor fixes to avoid the "Unchanged files with check annotations" notification when reviewing PRs:

  • added an alt-text to an image
  • updated uninformative link texts
  • fixed an anchor.

I am pretty confident the changes are ok, but maybe @skanwal or @naupaka could confirm it is fine before merging? Thanks!

Copy link

github-actions bot commented Nov 20, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-876

The following changes were observed in the rendered markdown documents:

 01-rstudio-intro.md  |    2 +-
 02-project-intro.md  |    4 +-
 03-seeking-help.md   |    4 +-
 08-plot-ggplot2.md   |    2 +-
 14-tidyr.md          |    2 +-
 15-knitr-markdown.md |    2 +-
 config.yaml (gone)   |   96 -----
 md5sum.txt           |   52 +--
 reference.md         |    2 +-
 renv.lock (gone)     | 1088 --------------------------------------------------
 10 files changed, 35 insertions(+), 1219 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-20 13:06:37 +0000

github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
@naupaka
Copy link
Member

naupaka commented Nov 21, 2023

Looks good to me! Thanks for these fixes.

@naupaka naupaka merged commit 9dd055c into swcarpentry:main Nov 21, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
Auto-generated via {sandpaper}
Source  : 9dd055c
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2023-11-21 00:06:03 +0000
Message : Merge pull request #876 from matthieu-bruneaux/main

Minor fixes (missing alt-text, uninformative link text, missing anchor)
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
Auto-generated via {sandpaper}
Source  : 346ac49
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-21 00:12:12 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 9dd055c
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2023-11-21 00:06:03 +0000
Message : Merge pull request #876 from matthieu-bruneaux/main

Minor fixes (missing alt-text, uninformative link text, missing anchor)
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
Auto-generated via {sandpaper}
Source  : 9dd055c
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2023-11-21 00:06:03 +0000
Message : Merge pull request #876 from matthieu-bruneaux/main

Minor fixes (missing alt-text, uninformative link text, missing anchor)
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
Auto-generated via {sandpaper}
Source  : f8142e4
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-21 00:14:20 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 9dd055c
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2023-11-21 00:06:03 +0000
Message : Merge pull request #876 from matthieu-bruneaux/main

Minor fixes (missing alt-text, uninformative link text, missing anchor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address check annotations from GitHub Actions
2 participants